Skip to content

make iterate configurable #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2020
Merged

make iterate configurable #488

merged 2 commits into from
Sep 24, 2020

Conversation

HDembinski
Copy link
Member

@HDembinski HDembinski commented Sep 24, 2020

@matthewfeickert @kratsg This patch makes the iteration ("try hard") feature of iminuit configurable. You should definitely try to play with the precision keyword, too, because I did and it improve convergence when the cost function has low precision (the doc string was extended to better explain what this setting does).

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #488 into develop will increase coverage by 0.79%.
The diff coverage is 97.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #488      +/-   ##
===========================================
+ Coverage    94.50%   95.30%   +0.79%     
===========================================
  Files           27       31       +4     
  Lines         2240     2937     +697     
  Branches        16        0      -16     
===========================================
+ Hits          2117     2799     +682     
- Misses         114      138      +24     
+ Partials         9        0       -9     
Impacted Files Coverage Δ
src/iminuit/IMinuitMixin.h 100.00% <ø> (ø)
src/iminuit/PythonCaller.h 100.00% <ø> (+8.88%) ⬆️
src/iminuit/PythonFCN.h 100.00% <ø> (ø)
src/iminuit/__init__.py 66.66% <ø> (ø)
src/iminuit/_deprecated.py 100.00% <ø> (ø)
src/iminuit/color.py 100.00% <ø> (ø)
src/iminuit/info.py 0.00% <0.00%> (ø)
src/iminuit/tests/test_color.py 100.00% <ø> (ø)
src/iminuit/tests/test_describe.py 68.47% <78.94%> (+2.26%) ⬆️
src/iminuit/util.py 86.17% <85.80%> (+1.71%) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d9809...ebb343f. Read the comment docs.

@matthewfeickert
Copy link
Member

This patch makes the iteration ("try hard") feature of iminuit configurable. You should definitely try to play with the precision keyword, too, because I did and it improve convergence when the cost function has low precision (the doc string was extended to better explain what this setting does).

Fantastic! Many thanks @HDembinski and we'll get on that (I'll make a follow up Issue on pyhf).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants