fix: Cast non-hashable types to floats in toms748_scan #2467
Conversation
* Adding tensorflow tests are very slow
matthewfeickert
added
tests
| ) | ||
|
|
||
| assert observed_limit == pytest.approx(observed_limit_default) | ||
| # FIXME: Remove float cast after TensorFlow support removed |
There was a problem hiding this comment.
@kratsg Running the TensorFlow tests is very slow and adds minutes to this run. As we're going to be dropping TensorFlow in the future, I think that we could probably just skip TensorFlow in these tests. Thoughts?
|
CI is currently failing for Apple silicon macOS. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 69 69
Lines 4543 4546 +3
Branches 804 805 +1
=======================================
+ Hits 4462 4465 +3
Misses 48 48
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return __all__ | ||
|
|
||
|
|
||
| def _interp(x, xp, fp): |
There was a problem hiding this comment.
| def _interp(x, xp, fp): | |
| def _interp(x, xp: list[float], fp): |
| def _interp(x, xp, fp): | ||
| tb, _ = get_backend() | ||
| return tb.astensor(np.interp(x, xp.tolist(), fp.tolist())) | ||
| # xp has already been turned into a list at this point |
There was a problem hiding this comment.
can drop this comment with a typehint above as suggested
matthewfeickert
deleted the
fix/make-toms748_scan-compatible-with-all-backends
branch
Description
Resolves #2466
As
toms748_scanuses caching of results it requires that the results are hashable objects, which arrays are not. So to keep using this approach convert to floats as needed.Add testing for all backends for the upper limits inference tests.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: