ENH Adds the details about the numpy arrays and strings #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Nov 29, 2021
jjerphan
approved these changes
Nov 29, 2021
glemaitre
approved these changes
Nov 29, 2021
Member
glemaitre
left a comment
glemaitre
left a comment
There was a problem hiding this comment.
LGTM for the changes.
I just realised that the post-history in PEP is only related to the mailing list posting to keep up-to-date with the community (something that we could think about in the future).
There is no date to acknowledge any change in a PEP. Basically, changes can be done to reflect the implementation but without any extra layer of complexity.
Since these changes here are not controversial, I will merge them. We can discuss later the SLEP process and if we want to have a more complex one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more details to SLEP007 regarding dtypes, containers and strings.
This PR is a follow up to #59 (comment)
CC @glemaitre @adrinjalali @jnothman