Unit tests: Fix docker compose convert by config
#326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Benoit <[email protected]>
Signed-off-by: Mathieu Benoit <[email protected]>
mathieu-benoit
commented
Jun 23, 2025
mathieu-benoit
changed the title
docker compose convert by config
Contributor
Author
|
All good now, ready for your review @astromechza, thanks! |
astromechza
approved these changes
Jun 23, 2025
Member
astromechza
left a comment
astromechza
left a comment
There was a problem hiding this comment.
Thanks @mathieu-benoit. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In unit tests, fix
docker composeconvertbyconfig, since https://github.com/docker/compose/releases/tag/v2.36.1, as per docker/compose#12850.Now, to run the unit tests locally,
docker compose versionshould be greater or equal tov2.36.1in your local machine.