This repository was archived by the owner on Jul 4, 2024. It is now read-only.
fix: add immage flag for . image convention#69
Merged
chris-stephenson merged 1 commit intomainfrom Feb 2, 2024
Merged
Conversation
592bbad to
ff616f9
Compare
astromechza
reviewed
Feb 1, 2024
astromechza
reviewed
Feb 1, 2024
astromechza
reviewed
Feb 1, 2024
astromechza
reviewed
Feb 1, 2024
Member
astromechza
left a comment
There was a problem hiding this comment.
Change looks good, just a duplicated typo in the flag description.
Signed-off-by: Chris Stephenson <chris.stephenson@humanitec.com>
ff616f9 to
3bbd109
Compare
Author
Fixed the duplicated text and rebased to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
-i|--imageflag to allow for specifying the image to override when theimageproperty in a score file has a value.Description
.containers.{containerId}.imagewhere the value is.What does this PR do?
It is a convention when working with score that setting the image to
.means: "the image in the current context". Usually, this means the image that is associated with the score file. The CI pipeline will know the generated image to be inserted.Today, there are a number of workarounds involving
--propertyoverrides (which require knowledge of the container IDs) or evensedscripts such as:This change will make updated in the current image much simpler:
Types of changes
Checklist: