-
Notifications
You must be signed in to change notification settings - Fork 119
A ton of changes and improvements #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ofiles, udp profiles, server ssl profiles, http profiles
…ult monitors. Adding debug flag and output for requests.
…vers. added and removed some other debugging mode output
…are not set to be explicity overridden from their parent profiles
…are not set to be explicity overridden from their parent profiles
I agree that breaking out the individual configuration objects into their own files would make management a little easier at this point, I think that would best be handled in a PR in itself. That being said, there is a lot going on here. Breaking the changes down into manageable scoped PRs would make reviewing them a lot easier. |
Your request is totally reasonable. Unfortunately there are so many changes that I would have to look over my git history and make PRs for an hour. I may get to this someday, but probably not soon... |
What about nesting calls using the |
@zlesnr I would agree with that; it should be modeled similarly how F5 structures their Python SDK: https://github.com/F5Networks/f5-common-python/tree/development/f5/bigip |
@zlesnr Good idea. Definitely easier to keep track of things. |
modifying ltm.go
I used this package for a recent project of mine and it was really helpful. I ended up having to expand this package with a bunch of different things, so I want to contribute back.
Some things worth noting:
bigip.Debug = true
Let me know if this stuff is suitable. Unfortunately, this package does not have any real tests so I can't say that it will continue to pass your tests.
Thanks for creating this!