Issue with new height sizing

[tmickel]

Hey @drigz,

Thanks for joining our meeting today- it was fun to have you.

I noticed a problem today - I think it might be related to our changes to the height calculation. The flyout is looking great, but check this out:

One block in a pants looks fine:

But with two, things aren't being sized correctly:

Any initial idea what might be causing this?

[tmickel]

@rachel-fenichel @drigz Now we seem to have reintroduced "jumpy pants"...can make a screencap later.

[drigz]

Sorry about all the regressions! I'm excited to find out what jumpy pants are...

[drigz]

Ooh, I figured it out! Is it how I can drag some blocks upwards by shadowing them repeatedly with pants? Will look into it!

PS. Perhaps you didn't anticipate this, but calling the control blocks pants is a lot of fun for a British person, and means I have a constant smile on my face while working on this project. Thanks!

[drigz]

Changing block_svg.js:1044 to call getHeightWidth(true) seems to fix this, but isn't a nice solution since use of the optional parameter is no longer confined to the horizontal rendering code.

It doesn't make sense to me that drawing the ghost block could move anything except the ghost block - do you know why the statement block gets moved?

[rachel-fenichel]

Drawing the insertion marker (ghost) renders all of the blocks before it in
the stack (basically in case some of them are pants; we'll be taking a look
to try to reduce the number of calls) and translates blocks after it in the
stack. That is, the insertion marker is a real block and it's really being
inserted into the stack. It just renders with a different color and no
icon.

On Fri, Apr 15, 2016 at 9:45 AM Rodrigo Queiro notifications@github.com
wrote:

Changing block_svg.js:1044 to call getHeightWidth(true) seems to fix this,
but isn't a nice solution since use of the optional parameter is no longer
confined to the horizontal rendering code.

It doesn't make sense to me that drawing the ghost block could move
anything except the ghost block - do you know why the statement block gets
moved?

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#224 (comment)

[drigz]

Moving to #232.