Don't consider ghosts when looking for the closest connection. #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with a manual calculation. getBBox() can cause the browser to re-layout the whole page and we have much of the information (e.g. individual block height and width) we need already cached. Note that getBoundingRectangle's calculation is slightly different than the one returned by getBBox. It is off by 3 in the y direction due to how one of the curves is drawn. This new calculation is technically more accurate.
Fix connection.closest and tests.
Require ConnectionDB where needed; recompile
Replace the call to getBBox() in getMainWorkspaceMetrics
…h a dragging stack.
This meant that variables could be called _, conflicting with use in Lua as a dummy variable, and in particular with scrubNakedValue.
Also fix a return type warning in one of the branches.
Don't connect a block with no next connection if that would force a b…
consider the last block on the stack when looking for places to attac…
Add missing comma to Lua reserved words
Some bugs in undoing function argument changes.
# Conflicts: # blockly_compressed_vertical.js # blockly_uncompressed_vertical.js # blocks/text.js # core/block_svg.js
Upstream merge March 15 & remove Lua generators
|
Looks good! |
Don't fire events for ghost blocks.
…m/rachel-fenichel/scratch-blockly into bugfix/ghost_different_workspaces
rachel-fenichel
referenced
this pull request
in rachel-fenichel/scratch-blockly
Mar 18, 2016
New branch due to merge problems with #125.
picklesrus
pushed a commit
to picklesrus/scratch-blocks
that referenced
this pull request
Aug 4, 2017
Using postcss-modules-values with imported values failed on our current basic usage; it is apparently not mature enough to be used yet. The syntax used by postcss-simple-vars is already familiar to most people familiar with modern CSS build systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120