Make Zoom center on Workspace and not Blockly #775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/workspace_svg.js
Outdated
| @@ -1348,6 +1348,15 @@ Blockly.WorkspaceSvg.prototype.zoomCenter = function(type) { | |||
| var metrics = this.getMetrics(); | |||
| var x = metrics.viewWidth / 2; | |||
| var y = metrics.viewHeight / 2; | |||
| if (this.options.toolboxPosition == 2) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rachel-fenichel
added a commit
to rachel-fenichel/scratch-blocks
that referenced
this pull request
Feb 15, 2017
…/generator_docstrings Update generator comments
rschamp
reviewed
Feb 21, 2017
core/workspace_svg.js
Outdated
| @@ -1348,6 +1348,13 @@ Blockly.WorkspaceSvg.prototype.zoomCenter = function(type) { | |||
| var metrics = this.getMetrics(); | |||
| var x = metrics.viewWidth / 2; | |||
| var y = metrics.viewHeight / 2; | |||
| if (this.options.toolboxPosition == Blockly.TOOLBOX_AT_LEFT) { | |||
| x = x + 250; | |||
| } else if (this.options.toolboxPosition == Blockly.TOOLBOX_AT_RIHT) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
This is still using magic numbers to perform the offset. Closing until we have time to come up with an alternative approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Part of #43
Proposed Changes
Make Zoom center on Workspace and not Blockly
Reason for Changes
So zoom does not look offset
Test Coverage
Please show how you have added tests to cover your changes