Skip to content

Commit 55f99e6

Browse files
authored
fix(scully-plugin-puppeteer): correctly track requests in bare project (#1610)
Previously, instead of adding/removing each request from the `requests` set, the set itself was added/removed. Since `Set` deduplicates its values, it would always contain just one item (regardless of how many requests would be pending) and it would be emptied once the first request was completed. This commit fixes this by adding/removing the actual request to/from the `requests` set.
1 parent 7463e05 commit 55f99e6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

libs/plugins/scully-plugin-puppeteer/src/lib/plugins-scully-plugin-puppeteer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ export const puppeteerRender = async (route: HandledRoute): Promise<string> => {
5757
// eslint-disable-next-line no-inner-declarations
5858
function registerRequest(request) {
5959
request.continue();
60-
requests.add(requests);
60+
requests.add(request);
6161
}
6262

6363
// eslint-disable-next-line no-inner-declarations
6464
function unRegisterRequest(request) {
6565
// request.continue();
66-
requests.delete(requests);
66+
requests.delete(request);
6767
}
6868

6969
pageLoaded

0 commit comments

Comments
 (0)