fix(scully-plugin-puppeteer): correctly track requests in bare project#1610
Merged
SanderElias merged 1 commit intoscullyio:mainfrom Sep 21, 2022
gkalpak:patch-1
Merged
fix(scully-plugin-puppeteer): correctly track requests in bare project#1610SanderElias merged 1 commit intoscullyio:mainfrom gkalpak:patch-1
SanderElias merged 1 commit intoscullyio:mainfrom
gkalpak:patch-1
Conversation
Previously, instead of adding/removing each request from the `requests` set, the set itself was added/removed. Since `Set` deduplicates its values, it would always contain just one item (regardless of how many requests would be pending) and it would be emptied once the first request was completed. This commit fixes this by adding/removing the actual request to/from the `requests` set.
|
|
SanderElias
approved these changes
Sep 21, 2022
Contributor
SanderElias
left a comment
SanderElias
left a comment
There was a problem hiding this comment.
@gkalpak Good catch! this is an obvious thing, once spotted!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, instead of adding/removing each request from the
requestsset, the set itself was added/removed. SinceSetdeduplicates its values, it would always contain just one item (regardless of how many requests would be pending) and it would be emptied once the first request was completed.This commit fixes this by adding/removing the actual request to/from the
requestsset.