feat(traverseapparoutes): make sure there is allwyas an root Route /#266
Merged
jorgeucano merged 1 commit intomasterfrom Feb 3, 2020
Merged
feat(traverseapparoutes): make sure there is allwyas an root Route /#266jorgeucano merged 1 commit intomasterfrom
/#266jorgeucano merged 1 commit intomasterfrom
Conversation
jorgeucano
approved these changes
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
if there is no
/route in the router, the index.html is the original version, and not rendered by ScullyIssue Number: N/A
What is the new behavior?
The
/route will always be rendered unless explicitly ignored by route configuration.Does this PR introduce a breaking change?