Skip to content

feat(traverseapparoutes): make sure there is allwyas an root Route / #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorgeucano merged 1 commit into from
Feb 3, 2020
Merged

feat(traverseapparoutes): make sure there is allwyas an root Route / #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions scully/routerPlugins/traverseAppRoutesPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,8 @@ ${green('When there are extraRoutes in your config, we will still try to render
// process.exit(15);
const allRoutes = [...routes, ...extraRoutes];
if (allRoutes.findIndex(r => r === '') === -1) {
logWarn(`

We did not find an empty route ({path:'', component:rootComponent}) in your app.
This means that the root of your application will be you normal angular app, and
is not rendered by Scully
In some circumstances this can be cause because a redirect like:
({path: '', redirectTo: 'home', pathMatch: 'full'})
is not picked up by our scanner.

${green(`By adding '' to the extraRoutes array in the scully.config option, you can bypass this issue`)}

`);
/** make sure the root Route is always rendered. */
allRoutes.push('');
}
return allRoutes;
};
Expand Down