Skip to content

assets/scully-routes.json not found when using baseHref option #694

@rpd10

Description

@rpd10

🐞 Bug report

Description

When deploying to GitHub Pages, I need to pass --base-href /my-project-name/ in order to set the <base> tag used for loading static assets in Angular. I cannot find a way to configure Scully with the same base. When loading the published page, Scully makes a request to https://.github.io/assets/scully-routes.json - instead it needs to request https://.github.io//assets/scully-routes.json

I would be willing to submit a PR for this. My initial thought is that ScullyRoutesService should optionally inject APP_BASE_HREF and if provided, use that value when fetching the scully-routes.json

🔬 Minimal Reproduction

https://github.com/rpd10/diehl-with-software/tree/live

💻Your Environment

Angular Version:


Angular CLI: 9.1.0
Node: 12.18.1
OS: darwin x64

Angular: 9.1.11
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Scully Version:


"@scullyio/init": "0.0.28",
    "@scullyio/ng-lib": "0.0.24",
    "@scullyio/scully": "0.0.98",

🔥 Exception or Error

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions