Skip to content

feat(sully): prepare scully for running inside Docker container #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SanderElias merged 1 commit into from
Jan 1, 2020
Merged

feat(sully): prepare scully for running inside Docker container #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scully/renderPlugins/launchedBrowser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {Browser, launch, LaunchOptions} from 'puppeteer';
import {Observable} from 'rxjs';
import {shareReplay, take} from 'rxjs/operators';
import {log} from '../utils/log';
import * as yargs from 'yargs';

const {showBrowser} = yargs
Expand All @@ -20,6 +21,12 @@ function obsBrowser(
args: ['--no-sandbox', '--disable-setuid-sandbox'],
}
): Observable<Browser> {
const { SCULLY_PUPPETEER_EXECUTABLE_PATH } = process.env;
if (SCULLY_PUPPETEER_EXECUTABLE_PATH) {
log(`Launching puppeteer with executablePath ${SCULLY_PUPPETEER_EXECUTABLE_PATH}`);
options.executablePath = SCULLY_PUPPETEER_EXECUTABLE_PATH;
options.args = [...options.args, '--disable-dev-shm-usage'];
}
return new Observable(obs => {
const promisedBrowser = launch(options);
promisedBrowser
Expand Down