Skip to content

fix(scully): make sure scully emits non-zero exit code on errors #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronfrost merged 1 commit into from
Dec 30, 2019
Merged

fix(scully): make sure scully emits non-zero exit code on errors #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scully/scully.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ let _options = {};
const folder = join(scullyConfig.homeFolder, scullyConfig.distFolder);

if (!existDistAngular(scullyConfig.homeFolder)) {
process.exit(0);
process.exit(15);
}

await moveDistAngular(folder, scullyConfig.outFolder, {removeStaticDist: true, reset: false});
Expand Down Expand Up @@ -105,7 +105,7 @@ let _options = {};

if (!(await waitForServerToBeAvailable().catch(e => false))) {
logError('Could not connect to server');
process.exit(0);
process.exit(15);
}
console.log('servers available');
await startScully();
Expand Down Expand Up @@ -179,5 +179,5 @@ export async function isBuildThere(config: ScullyConfig) {
return true;
}
logError(`Angular distribution files not found, run "ng build" first`);
process.exit(0);
process.exit(15);
}
2 changes: 1 addition & 1 deletion scully/utils/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const loadIt = async () => {
distFolder = angularConfig.projects[defaultProject].architect.build.options.outputPath;
} catch (e) {
logError(`Angular config file could not be parsed!`, e);
process.exit(0);
process.exit(15);
}

// TODO: update types in interfacesandenums to force correct types in here.
Expand Down