fix(scully-content.component): don't try to re-render content when navigating one level "up"#145
Merged
SanderElias merged 1 commit intomasterfrom Jan 5, 2020
Merged
Conversation
…igating one level "up" closes #121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #121
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
fixes a bug that ahppened when you navigated from a blog page to a level above. It tried to render the scully content for the new page, where it should not do that,
What is the current behavior?
throws error:
Issue Number: 121
What is the new behavior?
doesn't throw the error anymore
Does this PR introduce a breaking change?
Other information