refactor(scully): add husky and pretty-quick#147
Merged
aaronfrost merged 2 commits intomasterfrom Jan 7, 2020
Merged
Conversation
SanderElias
approved these changes
Jan 6, 2020
Contributor
SanderElias
left a comment
SanderElias
left a comment
There was a problem hiding this comment.
Isn't there more configuration needed for the prettier to run?
Aside from that, LGTM
Contributor
Author
|
yeap! The magic behind is made by precise-commits.... But, Im going to change by pretty-quick WhyPretty documentation says: precise-commitsUse Case: Great for when you want partial file formatting on your changed/staged files. pretty-quickUse Case: Great for when you want an entire file formatting on your changed/staged files. |
Villanuevand
changed the title
aaronfrost
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#143
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #143
What is the new behavior?
Does this PR introduce a breaking change?
Other information