docs: add polyfill.md#179
Merged
SanderElias merged 1 commit intoscullyio:masterfrom Jan 13, 2020
evolkmann:docs/polyfills
Merged
docs: add polyfill.md#179SanderElias merged 1 commit intoscullyio:masterfrom evolkmann:docs/polyfills
SanderElias merged 1 commit intoscullyio:masterfrom
evolkmann:docs/polyfills
Conversation
The `Event()` constuctor is used in the browser. To make this work in Internet Explorer, a polyfill is required. The new document describes the polyfilling process.
Contributor
|
@evolkmann You are aware that those events are only used inside our puppeteer rendering process, and that that is inheritly not Ie? |
Contributor
Author
|
Hi @SanderElias, I was not aware of that, but still it caused our app to crash. With the polyfill enabled, the error did not occur again. Here is a screenshot of the error report: |
Contributor
|
Thanks for the info.
I will log an issue for this because those should not fire in normal
operation. For now, the polyfill will fix your issue.
|
Contributor
Author
|
Hi @SanderElias, thanks for merging. Just curious, is it planned to remove the firing of those events in the browser at some point? Or is it indeed right that this code is executed in the browser? |
Contributor
|
Yes, I made a note to take care of this, but it can take a while before I get around to that. That's why I merged your docs PR, so anyone running into this can fund out the cause in the docs. |
Contributor
Author
|
Alright, thanks for clarifying! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
Event()constuctor is used in the project. To make this work in Internet Explorer, a polyfill is required.The new document describes the polyfilling process.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Scully is currently not working in Internet Explorer.
What is the new behavior?
The new doc describes the necessary polyfilling process.
Does this PR introduce a breaking change?
Other information
Reference to usage of
new Event():scully/projects/scullyio/ng-lib/src/lib/idleMonitor/idle-monitor.service.ts
Lines 25 to 27 in 27b79dd