feat(Scully config): adds an option to set the puppeteer launch options#184
Merged
jorgeucano merged 2 commits intomasterfrom Jan 15, 2020
Merged
feat(Scully config): adds an option to set the puppeteer launch options#184jorgeucano merged 2 commits intomasterfrom
jorgeucano merged 2 commits intomasterfrom
Conversation
jorgeucano
approved these changes
Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #181
add an option to the config to set puppeteers launch options. might be needed in restricted environments
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
None
Issue Number: #181
What is the new behavior?
have an option to address #181
Does this PR introduce a breaking change?