Sander/add config to handled route#206
Merged
jorgeucano merged 4 commits intomasterfrom Jan 21, 2020
Merged
Conversation
… passed correctly <ake sure it doesn't throw out the defaults if no specific route postRenderes are configured. Also pass the config into the handledRoute
jorgeucano
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Does not export httpGetJson helper.
per route config postRenderers erases the global set ones.
config is not available to renderplugins
What is the new behavior?
Now exports httpGetJson
route config only overwrite the global one if set on the given route
the route config object is now available on the handledRoute
Does this PR introduce a breaking change?