Skip to content

Schematics/fix dasherize spaces name #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorgeucano merged 7 commits into from
Dec 16, 2019
Merged

Schematics/fix dasherize spaces name #21

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
75eaf8e
schematics(fix): fix problems pre alpha for support scully.config.js
jorgeucano Dec 15, 2019
71c2ef7
schematics(fix): rename flag for post, for support schematics names\
jorgeucano Dec 15, 2019
614f021
schematics(post): add support for name with spaces
jorgeucano Dec 16, 2019
eec4bc0
Merge branch 'master' of https://github.com/scullyio/scully into sche…
jorgeucano Dec 16, 2019
5863e97
Merge branch 'master' of https://github.com/scullyio/scully into sche…
jorgeucano Dec 16, 2019
f0892e4
schematics(fix): fix inject into scully.config.js for support space i…
jorgeucano Dec 16, 2019
38ae875
schematics(fix): fix dasherize from folder and md name
jorgeucano Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schematics/scully/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion schematics/scully/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@scullyio/init",
"version": "0.0.4",
"version": "0.0.5",
"description": "Add scully to your angular app",
"repository": {
"type": "GIT",
Expand Down
5 changes: 3 additions & 2 deletions schematics/scully/src/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {apply, forEach, mergeWith, Rule, SchematicContext, Source, Tree} from '@angular-devkit/schematics';
import {strings} from '@angular-devkit/core';

interface Data {
name: string;
Expand All @@ -7,10 +8,10 @@ interface Data {
}

export function addRouteToScullyConfig(scullyConfigJs: string, data: Data) {
const addRoute = `\n '/${data.name}/:${data.slug}': {
const addRoute = `\n '/${strings.dasherize(data.name)}/:${data.slug}': {
type: '${data.type}',
${data.slug}: {
folder: "./${data.name}"
folder: "./${strings.dasherize(data.name)}"
}
},`;
let output;
Expand Down