Skip to content

refactor(content): fix typo into log #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SanderElias merged 1 commit into from
Jan 21, 2020
Merged

refactor(content): fix typo into log #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scully/renderPlugins/content-render-utils/insertContent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export function insertContent(startTag: string, endTag: string, html: string, in
const [takeout, endText] = rest.split(endTag);
return [openingText, startTag, insertText, endTag, ...extras, endText].join('');
} catch (e) {}
logWarn(`missing "${yellow('<scully-conent>')}" or "${yellow('httpClientModule')}"`);
logWarn(`missing "${yellow('<scully-content>')}" or "${yellow('httpClientModule')}"`);
return `<h1>Scully could not find the &lt.scully-content&gt. tag in this page.</h1>
<p>This error can happen when you forgot to put the mandatory "scully-content" in the component that is rendering this page?</p>
<p>It may also occur if the 'httpClientModule' is not load in your app.module</p>
Expand Down
6 changes: 3 additions & 3 deletions scully/renderPlugins/contentRenderPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ export async function contentRenderPlugin(html: string, route: HandledRoute) {
return insertContent(scullyBegin, scullyEnd, html, additionalHTML, getScript());
} catch (e) {
logWarn(
`Error, probably missing "${yellow('<scully-conent>')}" or "${yellow('httpClientModule')}" for ${yellow(
file
)}`
`Error, probably missing "${yellow('<scully-content>')}" or "${yellow(
'httpClientModule'
)}" for ${yellow(file)}`
);
}
}