feat(scully runtime config): user forRoot to pass config to Scully#271
Merged
SanderElias merged 2 commits intomasterfrom Feb 4, 2020
Merged
feat(scully runtime config): user forRoot to pass config to Scully#271SanderElias merged 2 commits intomasterfrom
SanderElias merged 2 commits intomasterfrom
Conversation
The transferState service now only gets activated when the config using forRoot says so.
jorgeucano
reviewed
Feb 3, 2020
Contributor
jorgeucano
left a comment
There was a problem hiding this comment.
I love it, but this is a breaking change if the people by default have false, we need add this into the document with the PR :)
Contributor
|
Im totally agree with @jorgeucano |
…event braking change This is a better default aas it's not breaking anymore, but still enables people to opt-out
Contributor
Author
|
I changed the default to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transferState service now only gets activated when the config using forRoot says so.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
transferStateServiceis always monitoring the route, and trying to load data, even whens/getStateis not used at all.What is the new behavior?
transferStateServiceis only monitoring if the user tells it so by using the config in forRootlike this:
Does this PR introduce a breaking change?
Other information