Skip to content

feat(staticserver): add option for use ssl into the static server#293

Merged
jorgeucano merged 3 commits intomasterfrom
feat/ssl
Feb 12, 2020
Merged

feat(staticserver): add option for use ssl into the static server#293
jorgeucano merged 3 commits intomasterfrom
feat/ssl

Conversation

@jorgeucano
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Add a new option for use ssl into the static scully server

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Copy Markdown
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jorgeucano
Copy link
Copy Markdown
Contributor Author

I add options for support to read files with ssl-cert ssl-key!
So now, you can use the selfcreated or your ssl.
@SanderElias @aaronfrost

Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeucano jorgeucano merged commit dbdfc89 into master Feb 12, 2020
@jorgeucano jorgeucano deleted the feat/ssl branch February 12, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants