Skip to content

refactor(ng-lib): change cleanDups to private#324

Merged
SanderElias merged 1 commit intoscullyio:masterfrom
geromegrignon:patch-1
Feb 26, 2020
Merged

refactor(ng-lib): change cleanDups to private#324
SanderElias merged 1 commit intoscullyio:masterfrom
geromegrignon:patch-1

Conversation

@geromegrignon
Copy link
Copy Markdown
Contributor

change cleanDups to private as it's an implementation detail

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

cleanDups is publicly accessible but meant to be an implementation detail as stated by @SanderElias on Gitter :

the cleandups is private, it is an implementation detail. (as content-routes can have multiple instances this makes sure they are not leaking into the app, wreaking havoc on lists)

What is the new behavior?

cleanDups is no longer accessible

Does this PR introduce a breaking change?

  • Yes
  • No

change cleanDups to private as it's an implementation detail
Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit 8a55ecc into scullyio:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants