Skip to content

feat(lib): add scully-plugin-flash-prevention to the repo#346

Merged
aaronfrost merged 2 commits intomasterfrom
frost/flash-prevention
Mar 3, 2020
Merged

feat(lib): add scully-plugin-flash-prevention to the repo#346
aaronfrost merged 2 commits intomasterfrom
frost/flash-prevention

Conversation

@aaronfrost
Copy link
Copy Markdown
Contributor

Added the scully flash prevention stuff into the repo. Make the flash prevention it's own lib. It is
deployable on it's own. It is installable on it's own.

BREAKING CHANGE:
None

ISSUES CLOSED: None

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Added the scully flash prevention stuff into the repo. Make the flash prevention it's own lib. It is
deployable on it's own. It is installable on it's own.

BREAKING CHANGE:
None

ISSUES CLOSED: None
Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I added a flash prevention test.
@aaronfrost aaronfrost merged commit 193982e into master Mar 3, 2020
@aaronfrost aaronfrost deleted the frost/flash-prevention branch March 3, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants