fix: slug folder

[jiverson]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/scullyio/scully/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Other... Please describe:

What is the current behavior?

In watch mode the folder location should point to the variable "slug" not the explicit folder "slug".

For example with a config settings:

exports.config = {
  projectRoot: "./src",
  projectName: "my-scully-blog",
  outDir: "./dist/static",
  routes: {
    "/blog/:postId": {
      type: "contentFolder",
      postId: {
        folder: "./blog"
      }
    }
  }
};

and after npm run scully you will receive the following error:

error into read the config TypeError: Cannot read property 'folder' of undefined
    at Object.checkStaticFolder (/Users/jiverson/dev/my-scully-blog/node_modules/@scullyio/scully/utils/fsFolder.js:24:64)
    at Object.watchMode (/Users/jiverson/dev/my-scully-blog/node_modules/@scullyio/scully/watchMode.js:37:22)
    at /Users/jiverson/dev/my-scully-blog/node_modules/@scullyio/scully/scully.js:84:25
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

Does this PR introduce a breaking change?

• Yes
• No

Other information

If you run in npm run scully --nw everything works.

[jiverson]

FYI: I am having issues running scully locally for example I can't get the tests to pass but they pass in the ci. Is there a development document available so I am able to double check my settings and verify the npm scripts I need to run?

[jorgeucano]

Hey @jiverson thanks for fix this mistake...
About the question, we run this

      - run: npm install
      - run: npm run compile:prod
      - run: node ./dist/scully/scully --tds --host='0.0.0.0' --nw --project=sampleBlog
      - run: npm run test
      - run: npm run e2e:server

So, in my computer i run something similar:

      - run: npm install
      - run: npm run compile:prod
      - run: node ./dist/scully/scully --tds --nw --project=sampleBlog
      - run: npm run test
      - run: npm run e2e:server

Thats all ... can you confirm me if this work for you?

[jiverson]

@jorgeucano Perfect thanks yes that all worked.