Skip to content

feat(scully): make getHandledRoutes promise available#404

Merged
jorgeucano merged 1 commit intomasterfrom
sander/routesAvailable
Mar 19, 2020
Merged

feat(scully): make getHandledRoutes promise available#404
jorgeucano merged 1 commit intomasterfrom
sander/routesAvailable

Conversation

@SanderElias
Copy link
Copy Markdown
Contributor

with thsi PR you can get the full list of routes when you need it. It is only available after the
routeDetection phase is done.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #374

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

with thsi PR you can get the full list of routes when you need it. It is only available _after_ the
routeDetection phase is done.
@jorgeucano jorgeucano self-requested a review March 19, 2020 14:06
Copy link
Copy Markdown
Contributor

@jorgeucano jorgeucano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeucano jorgeucano merged commit d6e490d into master Mar 19, 2020
@jorgeucano jorgeucano deleted the sander/routesAvailable branch March 19, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make list of Scully routes available inside (render) Plugins

2 participants