Skip to content

feat(scully): add support to set the number of cores during rendering,#420

Merged
jorgeucano merged 3 commits intomasterfrom
sander/tsStateExpansion
Mar 24, 2020
Merged

feat(scully): add support to set the number of cores during rendering,#420
jorgeucano merged 3 commits intomasterfrom
sander/tsStateExpansion

Conversation

@SanderElias
Copy link
Copy Markdown
Contributor

@SanderElias SanderElias commented Mar 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Currently, the number of concurrent rendering threads equals node cpus().length (all threads on all cores)

Issue Number: N/A

What is the new behavior?

Have a setting in scullyconfig that allows changing this to whatever value fits the app.
Also, add a utility function to the transfer state that makes it easier to incorporate using the Scully state

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jorgeucano jorgeucano merged commit 3596179 into master Mar 24, 2020
@jorgeucano jorgeucano deleted the sander/tsStateExpansion branch March 24, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants