Skip to content

feat(scully): support for markdown options like {:target="_blank"}#422

Merged
jorgeucano merged 3 commits intomasterfrom
sander/customMarkdownOptionsPlugin
Mar 24, 2020
Merged

feat(scully): support for markdown options like {:target="_blank"}#422
jorgeucano merged 3 commits intomasterfrom
sander/customMarkdownOptionsPlugin

Conversation

@SanderElias
Copy link
Copy Markdown
Contributor

@SanderElias SanderElias commented Mar 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

allow additional attributes to be added to target anchors. It uses the same syntax as jekyll and kramdownL

[someLink](http://somewhere.com){:target="_blank" class="lnk ext"}

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Comment thread scully/renderPlugins/customMarkdownOptions.ts Outdated
@jorgeucano jorgeucano merged commit b401d27 into master Mar 24, 2020
@jorgeucano jorgeucano deleted the sander/customMarkdownOptionsPlugin branch March 24, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants