fix(scully): fix different blogFolder name#433
Merged
SanderElias merged 5 commits intomasterfrom Mar 31, 2020
Merged
Conversation
Contributor
|
I want to approve, but I don't see a test. So it makes me nervous. Would this be hard to test to make sure we don't break it in the future? |
Contributor
Author
|
It needs quite some setup to do the test. Also, it is mostly covered by existing tests. |
Contributor
Author
|
Did push an update. Moved the blog files into a different folder, and this makes sure the test are ran for this change. The current tests will work just fine for this change now. No additional tests are needed @aaronfrost |
jorgeucano
approved these changes
Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
fails if blog-bost folder has a different name as the route does
Issue Number: N/A
What is the new behavior?
Generates ok
Does this PR introduce a breaking change?
Other information