Skip to content

fix(scully): fix different blogFolder name#433

Merged
SanderElias merged 5 commits intomasterfrom
sander/fixContentFolder
Mar 31, 2020
Merged

fix(scully): fix different blogFolder name#433
SanderElias merged 5 commits intomasterfrom
sander/fixContentFolder

Conversation

@SanderElias
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

fails if blog-bost folder has a different name as the route does

Issue Number: N/A

What is the new behavior?

Generates ok

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SanderElias SanderElias requested a review from jorgeucano March 29, 2020 08:03
@aaronfrost
Copy link
Copy Markdown
Contributor

I want to approve, but I don't see a test. So it makes me nervous. Would this be hard to test to make sure we don't break it in the future?

@SanderElias
Copy link
Copy Markdown
Contributor Author

It needs quite some setup to do the test. Also, it is mostly covered by existing tests.
It is a bit of a chore to set up an extra test for this, as we need to add an extra blog folder where the name of the folder isn't the same as the route for the blog. in addition to what we have.

@SanderElias
Copy link
Copy Markdown
Contributor Author

Did push an update. Moved the blog files into a different folder, and this makes sure the test are ran for this change. The current tests will work just fine for this change now. No additional tests are needed @aaronfrost

@SanderElias SanderElias requested a review from aaronfrost March 29, 2020 10:17
@SanderElias SanderElias merged commit 8352d56 into master Mar 31, 2020
@SanderElias SanderElias deleted the sander/fixContentFolder branch March 31, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants