Skip to content

fix(docsWeb): change routerLink to link on app-button in header#486

Merged
jorgeucano merged 1 commit intoscullyio:masterfrom
cmgriffing:fix-docs-header-links-undefined
Apr 21, 2020
Merged

fix(docsWeb): change routerLink to link on app-button in header#486
jorgeucano merged 1 commit intoscullyio:masterfrom
cmgriffing:fix-docs-header-links-undefined

Conversation

@cmgriffing
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

In the Header, the current docs site shows undefined in the path of the href. This breaks opening main menu links in a new tab.

Issue Number: N/A

What is the new behavior?

The routerLink input is fixed to be link as expected by the app-button component.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

image

@jorgeucano jorgeucano merged commit 056a6e5 into scullyio:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants