feat(scully): add exit by default when have a plugin error and cli option#496
Merged
jorgeucano merged 3 commits intomasterfrom Apr 23, 2020
Merged
feat(scully): add exit by default when have a plugin error and cli option#496jorgeucano merged 3 commits intomasterfrom
jorgeucano merged 3 commits intomasterfrom
Conversation
…he flag for dont use this funct
Contributor
Author
|
@spencerb02 this is the other PR for exit when have the error in the plugin |
spencerb02
approved these changes
Apr 23, 2020
spencerb02
left a comment
spencerb02
left a comment
There was a problem hiding this comment.
Looks good. I like that exiting the process is the default behavior. Well done!
Contributor
|
@jorgeucano The code was really good. However, I moved it a bit around. Now it works on all plugins and not only on render ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…he flag for dont use this funct
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #492 #493
What is the new behavior?
Does this PR introduce a breaking change?
Other information