fix(scully): fix defaultPostRenderers type#559
Merged
SanderElias merged 3 commits intoscullyio:masterfrom May 18, 2020
puku0x:fix-scully-config-type
Merged
fix(scully): fix defaultPostRenderers type#559SanderElias merged 3 commits intoscullyio:masterfrom puku0x:fix-scully-config-type
SanderElias merged 3 commits intoscullyio:masterfrom
puku0x:fix-scully-config-type
Conversation
SanderElias
approved these changes
May 18, 2020
Contributor
Author
|
@SanderElias Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
No, but I think tests for types are not needed in this time.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Linter says "
defaultPostRenderersis missing" which is an optional array.https://github.com/scullyio/scully/blob/master/libs/scully/src/lib/utils/config.ts#L74
What is the new behavior?
There should be no errors after the config file is generated.
Does this PR introduce a breaking change?
Other information
The document for the interface is synchronized to the latest
ScullyConfig.