fix(ng-lib): getCurrent method needs decodeURI#560
Merged
SanderElias merged 1 commit intoscullyio:masterfrom May 18, 2020
stevermeister:getCurrent-bug
Merged
fix(ng-lib): getCurrent method needs decodeURI#560SanderElias merged 1 commit intoscullyio:masterfrom stevermeister:getCurrent-bug
SanderElias merged 1 commit intoscullyio:masterfrom
stevermeister:getCurrent-bug
Conversation
Contributor
|
@stevermeister What problem does this solve? |
Contributor
Author
|
@SanderElias yes, sure here you are: https://scullyio.netlify.app/ and here is the code - it does not work because URL in the browser is - |
Contributor
|
Good catch |
SanderElias
approved these changes
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Condition
does not work because
curLocationis not decoded, so there are some extra symbols there.Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information