feat(monorepo): add option to flashPrevention so set other display type#617
Merged
SanderElias merged 1 commit intomasterfrom Jun 8, 2020
Merged
Conversation
When fhasl prevention is done, it sets the type to 'inherit'. This pr adds an option to set it to anything you need. ISSUES CLOSED: #608
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the flashPreventionPlugin is done, it sets the display type to inherit.
Issue Number: N/A
What is the new behavior?
the displayType is now an option, if you need something else as
inherityou can now set this as an optional parameter.Does this PR introduce a breaking change?
Other information