Skip to content

docs(lib-core): add more information about enabling manualIdle#621

Merged
SanderElias merged 1 commit intoscullyio:masterfrom
AnkitaSinghal:docs/manualIdle-enable
Jun 10, 2020
Merged

docs(lib-core): add more information about enabling manualIdle#621
SanderElias merged 1 commit intoscullyio:masterfrom
AnkitaSinghal:docs/manualIdle-enable

Conversation

@AnkitaSinghal
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe: docs

What is the current behavior?

There is no information present about how to disable scully ready mechanism and add custom one

Issue Number: N/A

What is the new behavior?

Added information about the manualIdle flag and how to trigger the app ready event manually.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuzmanPI canyou have a look too?

@GuzmanPI
Copy link
Copy Markdown
Contributor

GuzmanPI commented Jun 9, 2020

Sure thing!

@SanderElias SanderElias merged commit 48770a4 into scullyio:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants