Skip to content

fix(lib): remove scroll event after angular load in flash prevention#737

Merged
jorgeucano merged 3 commits intomainfrom
fix/flash-prevention-scroll
Jul 13, 2020
Merged

fix(lib): remove scroll event after angular load in flash prevention#737
jorgeucano merged 3 commits intomainfrom
fix/flash-prevention-scroll

Conversation

@jorgeucano
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Sometimes when use the flash-prevention the scroll event continue working after run angular

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jorgeucano jorgeucano requested a review from SanderElias July 13, 2020 14:20
Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,,

@jorgeucano jorgeucano merged commit b09ae1e into main Jul 13, 2020
@jorgeucano jorgeucano deleted the fix/flash-prevention-scroll branch July 13, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants