Skip to content

fix(scully): use processed routes instead of original ones #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SanderElias merged 1 commit into from
Jul 14, 2020
Merged

fix(scully): use processed routes instead of original ones #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/scully/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@scullyio/scully",
"version": "0.0.101",
"version": "0.0.102",
"description": "Scully CLI",
"repository": {
"type": "GIT",
Expand Down
6 changes: 3 additions & 3 deletions libs/scully/src/lib/utils/handlers/defaultAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ async function plugin(localBaseFilter = baseFilter): Promise<HandledRoute[]> {
/** launch the browser, its shared among renderers */
await launchedBrowser();
/** start handling each route, works in chunked parallel mode */
await renderParallel(handledRoutes);
await renderParallel(processedRoutes);
/** wait for routeDiscoveryDone plugins to be ready. they can still be running. */
await discoveryDone;
/** fire off the allDone plugins */
await handleAllDone(handledRoutes);
return handledRoutes;
await handleAllDone(processedRoutes);
return processedRoutes;
} catch (e) {
// TODO: add better error handling
log(e);
Expand Down