feat(schematics): add prompts#89
Merged
jorgeucano merged 2 commits intoscullyio:masterfrom Jan 7, 2020
Merged
Conversation
Contributor
|
Thank you @timdeschryver |
Contributor
Author
|
Thanks for the update, there's no rush - enjoy the holidays 🎄 |
aaronfrost
previously approved these changes
Dec 27, 2019
| "type": "string", | ||
| "description": "add the name for the folder and module" | ||
| "description": "add the name for the folder and module", | ||
| "x-prompt": "What should be the name for the folder and module?" |
Contributor
There was a problem hiding this comment.
grammar: What name do you want to use for the folder and module?
| "name": { | ||
| "type": "string", | ||
| "description": "add the title for the post", | ||
| "x-prompt": "What should be the title for the post?" |
Contributor
There was a problem hiding this comment.
grammar: What should title do you want to use for the post?
Contributor
Author
There was a problem hiding this comment.
I think there's a typo, it should be What title do you want to use for the post right?
| "type": "string", | ||
| "description": "add the name for the :${slug}" | ||
| "description": "add the name for the :${slug}", | ||
| "x-prompt": "What should be the slug for the markdown?" |
Contributor
There was a problem hiding this comment.
grammar: What slug do you want for the markdown file?
Contributor
|
@timdeschryver I made a few grammar suggestions. |
Contributor
Author
|
👍, thanks @aaronfrost ! |
timdeschryver
force-pushed
the
schematic-prompts
branch
from
a1a0f5a to
11ec08f
Compare
|
|
jorgeucano
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
While running the schematics (
ng-addorgenerate) we have to remember the options.If we don't add options, the schematic will do nothing.
Issue Number: N/A
What is the new behavior?
The user will be prompted if she doesn't provide the options:
Does this PR introduce a breaking change?
Other information
Formatting is changed due to prettier.