Skip to content

Conversation

@giovp
Copy link
Member

@giovp giovp commented Feb 27, 2023

  • re-add the categorical conversion as discussed on zulip.
  • re-add the index argument to shapes.parse for matching it with instance_key in tables

seems that it still has some commits from the format branch merged shortly before, but are not relevant

linked PR:

@giovp giovp requested a review from LucaMarconato February 27, 2023 12:53
@LucaMarconato
Copy link
Member

LucaMarconato commented Feb 27, 2023

Looks good to me. I like the new versioning and format system, very clean!

@LucaMarconato LucaMarconato merged commit 4fb3433 into main Feb 27, 2023
@giovp giovp deleted the io/fixes branch February 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants