Skip to content

minor fix for points model parser #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 27, 2023
Merged

minor fix for points model parser #157

merged 8 commits into from
Feb 27, 2023

Conversation

giovp
Copy link
Member

@giovp giovp commented Feb 27, 2023 •
edited
Loading

  • re-add the categorical conversion as discussed on zulip.
  • re-add the index argument to shapes.parse for matching it with instance_key in tables

seems that it still has some commits from the format branch merged shortly before, but are not relevant

linked PR:

@giovp giovp requested a review from LucaMarconato February 27, 2023 12:53
@LucaMarconato
Copy link
Member

LucaMarconato commented Feb 27, 2023 •
edited
Loading

Looks good to me. I like the new versioning and format system, very clean!

@LucaMarconato LucaMarconato merged commit 4fb3433 into main Feb 27, 2023
@giovp giovp deleted the io/fixes branch February 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaMarconato LucaMarconato LucaMarconato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovp @LucaMarconato