ci: fix ConsistencyTwoNodeClusterTests #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scylla only supports EACH_QUORUM for writes. Apparently, Cassandra introduced support for EACH_QUORUM reads in version 3.x. This is not true for Scylla, though - that's why we need to expect an error from Scylla.
Thanks to the fix from the previous commit, we can enable this test suite in CI.
muzarski
force-pushed
the
consistency-two-nodes-tests-fix
branch
from
cae7e33 to
70b63de
Compare
dkropachev
approved these changes
Sep 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EACH_QUORUM for Scylla
Scylla does not support
EACH_QUORUMreads. The integration tests code needed to be adjusted for it.ConsistencyTwoNodeClusterTests
Enabled this test suite (can do that thanks to the EACH_QUORUM fix).
Pre-review checklist
.github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.