cass_session_free waits for session close
#338
Merged
+35
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparatory step for fixing cass_session_free in the next commit.
Quoting `cassandra.h` documentation of `cass_session_free`: > Frees a session instance. If the session is still connected it will > be synchronously closed before being deallocated. This is definitely not the case in the Rust wrapper, which simply deallocates the session without waiting for the requests to complete. This commit makes `cass_session_free` wait for the session to close, satisfying the contract.
Lorak-mmk
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extracted prefix of #328 that I have no doubts about. It makes
cass_session_freeblock until the session is closed, i.e., all running requests are completed. This is whatcassandra.h, as well as theAsyncClosetest, specify.Pre-review checklist
[ ] I have enabled appropriate tests inMakefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.[ ] I added appropriateFixes:annotations to PR description.