session_builder: Stress that new options should go to proper mode #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has happened several times that a configuration option (a method) for `GenericSessionBuilder` was implemented on `SessionBuilder` only, even though it suited `CloudSessionBuilder` as well. To protect against such mistakes: - all three `impl` blocks (both specific ones and the generic one) are guarded with comments, - `impl SessionBuilder` block is renamed to `impl GenericSessionBuilder<DefaultMode>` to highlight that this is a specific implementation only.
piodul
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has happened several times that a configuration option (a method) for
GenericSessionBuilderwas implemented onSessionBuilderonly, even though it suitedCloudSessionBuilderas well. To protect against such mistakes:implblocks (both specific ones and the generic one) are guarded with comments,impl SessionBuilderblock is renamed toimpl GenericSessionBuilder<DefaultMode>to highlight that this is a specific implementation only.Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.