Skip to content
This repository was archived by the owner on Feb 3, 2018. It is now read-only.

Improve error messages then a VCS operation fails. #193

Merged
merged 1 commit into from
Mar 12, 2017

Conversation

tomwilkie
Copy link
Contributor

Instead of errors like this:

solve error: No valid source could be created:
	failed to set up "", error Unable to retrieve local repo information	failed to set up "", error Unable to update repository	failed to set up "", error Unable to update repository	failed to set up "", error Unable to update repository

This changes gives us errors like this:

solve error: No valid source could be created:
	failed to set up "https://github.com/jmespath/go-jmespath", error Unable to retrieve local repo information	failed to set up "ssh://[email protected]/jmespath/go-jmespath", error Unable to update repository	failed to set up "git://github.com/jmespath/go-jmespath", error Unable to update repository	failed to set up "http://github.com/jmespath/go-jmespath", error Unable to update repository

Part of golang/dep#320

@codecov
Copy link

codecov bot commented Mar 12, 2017

Codecov Report

Merging #193 into master will increase coverage by 0.34%.
The diff coverage is 12.5%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   79.15%   79.49%   +0.34%     
==========================================
  Files          24       24              
  Lines        3804     3804              
==========================================
+ Hits         3011     3024      +13     
+ Misses        596      585      -11     
+ Partials      197      195       -2
Impacted Files Coverage Δ
maybe_source.go 80% <12.5%> (ø)
analysis.go 89.87% <0%> (+3.37%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072e002...1d32941. Read the comment docs.

@sdboyer
Copy link
Owner

sdboyer commented Mar 12, 2017

hah, we cross-posted :)

I'll take this, and then make a couple small additions to fix my other notes in #192. thanks!

@sdboyer sdboyer merged commit ee4e0c2 into sdboyer:master Mar 12, 2017
@tomwilkie
Copy link
Contributor Author

Thanks!

@tomwilkie tomwilkie deleted the improve-error-message branch March 12, 2017 13:51
krisnova pushed a commit to krisnova/dep that referenced this pull request Apr 21, 2017
Improve error messages then a VCS operation fails.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants