Element: add feature gate for test_call_async #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI fails due to GStreamer version being 1.12.2. |
Owner
|
Oops! |
Owner
|
Merged it manually, into master though. |
Owner
I'm going to update once 1.14.0 is out soon :) But even then it will still fail due to the pollfd API in GstBus: --all-features would enable the Windows and Unix version, and then the build fails because the same function is defined twice. I think I'll have to move away from --all-features for travis somehow. Do you have any suggestions? |
Contributor
Author
|
I think I do :). See #94 |
charlie-ht
pushed a commit
to charlie-ht/gstreamer-rs
that referenced
this pull request
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.