fix: only check scheme after Policy return follow
#2710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Jun 3, 2025
Bumps reqwest from 0.12.18 to 0.12.19. Release notes Sourced from reqwest's releases. v0.12.19 What's Changed refactor: report custom reason phrase in error message by @chanbengz in seanmonstar/reqwest#2697 fix: only check scheme after Policy return follow by @linyihai in seanmonstar/reqwest#2710 ci: check cookies feature on wasm target by @seanmonstar in seanmonstar/reqwest#2711 fix(redirect): Using tower-http patch to fix invalid content-length header by @linyihai in seanmonstar/reqwest#2709 Full Changelog: seanmonstar/[email protected] Changelog Sourced from reqwest's changelog. v0.12.19 Fix redirect that changes the method to GET should remove payload headers. Fix redirect to only check the next scheme if the policy action is to follow. (wasm) Fix compilation error if cookies feature is enabled (by the way, it's a noop feature in wasm). Commits 8cf142b v0.12.19 35b6c83 fix(redirect): Using tower-http patch to fix invalid content-length heade... a54c4cf disable util::add_cookie_header on wasm targets a7a2db1 ci: check cookies feature on wasm target 522638d fix: only check scheme after redirect Policy return follow (#2710) 2fde244 ci: apparently dependabot doesn't understand increase-if-necessary 35a6601 refactor: report custom reason phrase in error message (#2697) 5e03d04 chore(ci): make dependabot tell us of breaking changes we could upgrade to (#... See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a patch for #2617.
In #2617 refactoring PR, the scheme check firstly before the
Policydo redirection, this violates the logic before the refactoring.Solution
Move the
schemecheck logic onlypolicyreturnfollowAbout test
This PR add a test to prove that the old behavior should be follow.
Without ssl/tls setup enviroment, the test about
https_onlydo not include.