Remove some unused dependencies #2716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only used for pinning version.
Xuanwo
reviewed
Jun 5, 2025
| @@ -5,11 +5,11 @@ use support::server; | |||
|
|
|||
| use std::env; | |||
|
|
|||
| use once_cell::sync::Lazy; | |||
| use std::sync::LazyLock; | |||
There was a problem hiding this comment.
it's a test file, it should be fine no?
| percent-encoding = "2.3" | ||
| tokio = { version = "1.0", default-features = false, features = ["net", "time"] } | ||
| tower = { version = "0.5.2", default-features = false, features = ["timeout", "util"] } | ||
| tower-http = { version = "0.6.5", default-features = false, features = ["follow-redirect"] } | ||
| pin-project-lite = "0.2.11" | ||
| ipnet = "2.3" |
There was a problem hiding this comment.
Code search shows that we don't use any API from this anymore: https://github.com/search?q=repo%3Aseanmonstar%2Freqwest+ipnet&type=code
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Jun 11, 2025
Bumps reqwest from 0.12.19 to 0.12.20. Release notes Sourced from reqwest's releases. v0.12.20 Highlights Add ClientBuilder::tcp_user_timeout(Duration) option to set TCP_USER_TIMEOUT. Fix proxy headers only using the first matched proxy. (wasm) Fix re-adding Error::is_status(). What's Changed fix(client): apply authorization header to first matching proxy only by @0x676e67 in seanmonstar/reqwest#2714 wasm: re-add Error::is_status() by @seanmonstar in seanmonstar/reqwest#2720 properly match error variants in test by @Ruben2424 in seanmonstar/reqwest#2721 refactor: reduce size of Pending request future by @seanmonstar in seanmonstar/reqwest#2725 feat: add tcp_user_timeout builder option by @seanmonstar in seanmonstar/reqwest#2724 refactor: use hyper-util Socks connectors by @seanmonstar in seanmonstar/reqwest#2726 Remove some unused dependencies by @DaniPopes in seanmonstar/reqwest#2716 New Contributors @DaniPopes made their first contribution in seanmonstar/reqwest#2716 Full Changelog: seanmonstar/[email protected] Changelog Sourced from reqwest's changelog. v0.12.20 Add ClientBuilder::tcp_user_timeout(Duration) option to set TCP_USER_TIMEOUT. Fix proxy headers only using the first matched proxy. (wasm) Fix re-adding Error::is_status(). Commits 099ae80 v0.12.20 4bccf41 chore: remove some unused dependencies (#2716) 9248770 refactor: use hyper-util Socks connectors (#2726) 334837c feat: add tcp_user_timeout builder option (#2724) 13487fb refactor: reduce size of Pending request future (#2725) a26879d tests: properly match http3 error variants (#2721) 65102c9 wasm: re-add Error::is_status() (#2720) f94c5cd fix(proxy): apply headers to first matching proxy only (#2714) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
|
@seanmonstar That slab call breaks http3 support under wasm32 #2728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an unused dependency, and make others optional to only the feature they're needed for.
This is achieved through enabling the
unused_crate_dependencieslint (only for non-dev-deps), and checking withcargo hack check --each-feature.Towards #2712.
See individual commits for the full list of changes.