This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Update --min-lines to force it as a integer #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will fix #181 Though Im not sure if it is the correct method. But as symfony ArgvInput is missing type casting, I think this is the only way to fix it
|
Ah yeah nice! please merge this :-) @sebastianbergmann |
|
@sebastianbergmann you are so fast :-) |
|
The only problem I see is if you type --min-lines=lsv - some unforseen problems could happen. Though as this is a development tool, and not a "production" tool - I think its still OK. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #181
Though Im not sure if it is the correct method.
But as symfony ArgvInput is missing type casting, I think this is the only way to fix it